Conversation
ysjprojects
requested review from
lantiga,
t-vi and
williamFalcon
as code owners
Collaborator
|
@ysjprojects mind have look at the failing tests: |
Borda
reviewed
Mar 20, 2025
Borda
reviewed
Mar 20, 2025
Borda
reviewed
Mar 20, 2025
Borda
reviewed
Mar 20, 2025
Borda
reviewed
Mar 20, 2025
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Collaborator
Author
Hey @Borda, the first test was fixed. For the second test, it runs successfully but only when transformers is upgraded to 4.49.0 It's a specific issue with phi-4-mini-instruct that is backward incompatible with previous versions. I have also raised this issue here: #1968 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Phi 4 Mini Instruct 3.8B language model.
See issue #1948